From 23bc2d9db4f3b196bb26a5fff122791d4fec79ce Mon Sep 17 00:00:00 2001 From: "U-BASIS\\dsmyda" Date: Tue, 18 Sep 2018 11:07:38 -0400 Subject: [PATCH] Fixed Codacy issues, realized this bug also caused duplicating of first row in the binary excel files --- .../autopsy/tabulardatareader/ExcelReader.java | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/Core/src/org/sleuthkit/autopsy/tabulardatareader/ExcelReader.java b/Core/src/org/sleuthkit/autopsy/tabulardatareader/ExcelReader.java index e348990348..4d0711fc40 100755 --- a/Core/src/org/sleuthkit/autopsy/tabulardatareader/ExcelReader.java +++ b/Core/src/org/sleuthkit/autopsy/tabulardatareader/ExcelReader.java @@ -18,6 +18,7 @@ */ package org.sleuthkit.autopsy.tabulardatareader; +import static com.google.common.collect.Lists.newArrayList; import java.io.File; import java.io.FileInputStream; import java.io.IOException; @@ -176,17 +177,13 @@ public final class ExcelReader extends AbstractReader { Iterator sheetIter = workbook.getSheet(tableName).rowIterator(); while (sheetIter.hasNext()) { - Row r = sheetIter.next(); - for (Cell cell : r) { + Row row = sheetIter.next(); + for (Cell cell : row) { String index = String.valueOf(cell.getColumnIndex()); if (columnViewOfSheet.containsKey(index)) { columnViewOfSheet.get(index).add(getCellValue(cell)); } else { - columnViewOfSheet.put(index, new ArrayList() { - { - add(getCellValue(cell)); - } - }); + columnViewOfSheet.put(index, newArrayList(getCellValue(cell))); } } }