From 5abc587349eb3cf3ff01b005f59214a0799e26e2 Mon Sep 17 00:00:00 2001 From: William Schaefer Date: Wed, 16 Jan 2019 13:46:09 -0500 Subject: [PATCH] 4629 add comment to explain possible combining of OSInfo objects --- .../casemodule/datasourceSummary/DataSourceSummaryPanel.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Core/src/org/sleuthkit/autopsy/casemodule/datasourceSummary/DataSourceSummaryPanel.java b/Core/src/org/sleuthkit/autopsy/casemodule/datasourceSummary/DataSourceSummaryPanel.java index 0cac9d0c70..d1573a4dae 100644 --- a/Core/src/org/sleuthkit/autopsy/casemodule/datasourceSummary/DataSourceSummaryPanel.java +++ b/Core/src/org/sleuthkit/autopsy/casemodule/datasourceSummary/DataSourceSummaryPanel.java @@ -83,6 +83,7 @@ final class DataSourceSummaryPanel extends javax.swing.JPanel { SleuthkitCase skCase = Case.getCurrentCaseThrows().getSleuthkitCase(); allIngestJobs.addAll(skCase.getIngestJobs()); dataSources.addAll(skCase.getDataSources()); + //if for some reason multiple OS_INFO_ARTIFACTS were created with the same parent object id this will only return one OSInfo object for them osInfoList = OSUtility.getOSInfo(skCase); } catch (TskCoreException | NoCurrentCaseException ex) { logger.log(Level.SEVERE, "Failed to load ingest jobs.", ex); @@ -118,7 +119,7 @@ final class DataSourceSummaryPanel extends javax.swing.JPanel { //assumes only one Operating System per datasource //get the datasource id from the OSInfo's first artifact if it has artifacts if (!osInfo.getArtifacts().isEmpty() && osInfo.getArtifacts().get(0).getDataSource().getId() == selectedDataSource.getId()) { - if (!osName.isEmpty()){ + if (!osName.isEmpty()) { osName += ", "; } osName += osInfo.getOSName();