From d730cb714a80953771cd830deaee6c82cce87db1 Mon Sep 17 00:00:00 2001 From: William Schaefer Date: Fri, 10 May 2019 12:03:23 -0400 Subject: [PATCH] 4961 third pass at clean up mainly making classes final --- .../autopsy/contentviewers/WindowsRegistryViewer.java | 1 - Core/src/org/sleuthkit/autopsy/rejview/HexView.java | 2 +- .../sleuthkit/autopsy/rejview/RegeditExeValueFormatter.java | 2 +- Core/src/org/sleuthkit/autopsy/rejview/RejTreeKeyNode.java | 2 +- Core/src/org/sleuthkit/autopsy/rejview/RejTreeKeyView.java | 2 +- .../sleuthkit/autopsy/rejview/RejTreeNodeSelectionEvent.java | 2 +- .../autopsy/rejview/RejTreeNodeSelectionListener.java | 4 ++-- Core/src/org/sleuthkit/autopsy/rejview/RejTreeValueNode.java | 2 +- Core/src/org/sleuthkit/autopsy/rejview/RejTreeValueView.java | 2 +- Core/src/org/sleuthkit/autopsy/rejview/RejTreeView.java | 2 +- Core/src/org/sleuthkit/autopsy/rejview/RejView.java | 2 +- 11 files changed, 11 insertions(+), 12 deletions(-) diff --git a/Core/src/org/sleuthkit/autopsy/contentviewers/WindowsRegistryViewer.java b/Core/src/org/sleuthkit/autopsy/contentviewers/WindowsRegistryViewer.java index 0f8aa62a65..d68806cbd9 100644 --- a/Core/src/org/sleuthkit/autopsy/contentviewers/WindowsRegistryViewer.java +++ b/Core/src/org/sleuthkit/autopsy/contentviewers/WindowsRegistryViewer.java @@ -21,7 +21,6 @@ */ package org.sleuthkit.autopsy.contentviewers; - import com.williballenthin.rejistry.RegistryHive; import com.williballenthin.rejistry.RegistryHiveBuffer; import com.williballenthin.rejistry.RegistryParseException; diff --git a/Core/src/org/sleuthkit/autopsy/rejview/HexView.java b/Core/src/org/sleuthkit/autopsy/rejview/HexView.java index 79aa38336b..fbd29418bc 100644 --- a/Core/src/org/sleuthkit/autopsy/rejview/HexView.java +++ b/Core/src/org/sleuthkit/autopsy/rejview/HexView.java @@ -50,7 +50,7 @@ import org.sleuthkit.autopsy.coreutils.Logger; * estimate it to load three strings with length equal to the given ByteBuffer. * So its probably not good to use this view with large files. */ -class HexView extends JPanel implements CaretListener { +final class HexView extends JPanel implements CaretListener { private final static int DEFAULT_BYTES_PER_LINE = 0x10; private final static char[] HEX_DIGITS = {'0', '1', '2', '3', '4', '5', '6', '7', '8', '9', 'A', 'B', 'C', 'D', 'E', 'F'}; diff --git a/Core/src/org/sleuthkit/autopsy/rejview/RegeditExeValueFormatter.java b/Core/src/org/sleuthkit/autopsy/rejview/RegeditExeValueFormatter.java index fcf2c97adc..66550fb424 100644 --- a/Core/src/org/sleuthkit/autopsy/rejview/RegeditExeValueFormatter.java +++ b/Core/src/org/sleuthkit/autopsy/rejview/RegeditExeValueFormatter.java @@ -34,7 +34,7 @@ import java.util.Iterator; * example, see the nice sample here: * http://raja5.files.wordpress.com/2009/08/wincleanup_regedit.jpg */ -class RegeditExeValueFormatter { +final class RegeditExeValueFormatter { static String format(ValueData val) throws UnsupportedEncodingException, RegistryParseException { StringBuilder sb = new StringBuilder(); diff --git a/Core/src/org/sleuthkit/autopsy/rejview/RejTreeKeyNode.java b/Core/src/org/sleuthkit/autopsy/rejview/RejTreeKeyNode.java index 101779f9e1..2295034b47 100644 --- a/Core/src/org/sleuthkit/autopsy/rejview/RejTreeKeyNode.java +++ b/Core/src/org/sleuthkit/autopsy/rejview/RejTreeKeyNode.java @@ -32,7 +32,7 @@ import java.util.List; import java.util.logging.Level; import org.sleuthkit.autopsy.coreutils.Logger; -public class RejTreeKeyNode implements RejTreeNode { +public final class RejTreeKeyNode implements RejTreeNode { private static final Logger logger = Logger.getLogger(RejTreeKeyNode.class.getName()); private final RegistryKey _key; diff --git a/Core/src/org/sleuthkit/autopsy/rejview/RejTreeKeyView.java b/Core/src/org/sleuthkit/autopsy/rejview/RejTreeKeyView.java index b92ef084ce..c7765faaff 100644 --- a/Core/src/org/sleuthkit/autopsy/rejview/RejTreeKeyView.java +++ b/Core/src/org/sleuthkit/autopsy/rejview/RejTreeKeyView.java @@ -35,7 +35,7 @@ import javax.swing.JScrollPane; import javax.swing.JTable; import javax.swing.SwingConstants; -public class RejTreeKeyView extends RejTreeNodeView { +public final class RejTreeKeyView extends RejTreeNodeView { private static final long serialVersionUID = 1L; private final RejTreeKeyNode _node; diff --git a/Core/src/org/sleuthkit/autopsy/rejview/RejTreeNodeSelectionEvent.java b/Core/src/org/sleuthkit/autopsy/rejview/RejTreeNodeSelectionEvent.java index 3409e0998d..565caeb28b 100644 --- a/Core/src/org/sleuthkit/autopsy/rejview/RejTreeNodeSelectionEvent.java +++ b/Core/src/org/sleuthkit/autopsy/rejview/RejTreeNodeSelectionEvent.java @@ -21,7 +21,7 @@ */ package org.sleuthkit.autopsy.rejview; -public class RejTreeNodeSelectionEvent { +public final class RejTreeNodeSelectionEvent { private final RejTreeNode _node; diff --git a/Core/src/org/sleuthkit/autopsy/rejview/RejTreeNodeSelectionListener.java b/Core/src/org/sleuthkit/autopsy/rejview/RejTreeNodeSelectionListener.java index d6460e2197..3d496346d5 100644 --- a/Core/src/org/sleuthkit/autopsy/rejview/RejTreeNodeSelectionListener.java +++ b/Core/src/org/sleuthkit/autopsy/rejview/RejTreeNodeSelectionListener.java @@ -21,7 +21,7 @@ */ package org.sleuthkit.autopsy.rejview; -interface RejTreeNodeSelectionListener { +public interface RejTreeNodeSelectionListener { - abstract void nodeSelected(RejTreeNodeSelectionEvent e); + public abstract void nodeSelected(RejTreeNodeSelectionEvent e); } diff --git a/Core/src/org/sleuthkit/autopsy/rejview/RejTreeValueNode.java b/Core/src/org/sleuthkit/autopsy/rejview/RejTreeValueNode.java index a51e11bbca..c3008d5fcf 100644 --- a/Core/src/org/sleuthkit/autopsy/rejview/RejTreeValueNode.java +++ b/Core/src/org/sleuthkit/autopsy/rejview/RejTreeValueNode.java @@ -30,7 +30,7 @@ import org.openide.util.NbBundle.Messages; import java.util.logging.Level; import org.sleuthkit.autopsy.coreutils.Logger; -public class RejTreeValueNode implements RejTreeNode { +public final class RejTreeValueNode implements RejTreeNode { private static final Logger logger = Logger.getLogger(RejTreeValueNode.class.getName()); private final RegistryValue _value; diff --git a/Core/src/org/sleuthkit/autopsy/rejview/RejTreeValueView.java b/Core/src/org/sleuthkit/autopsy/rejview/RejTreeValueView.java index 6b003dbe94..4fbf596b13 100644 --- a/Core/src/org/sleuthkit/autopsy/rejview/RejTreeValueView.java +++ b/Core/src/org/sleuthkit/autopsy/rejview/RejTreeValueView.java @@ -31,7 +31,7 @@ import javax.swing.JLabel; import javax.swing.JScrollPane; import javax.swing.SwingConstants; -public class RejTreeValueView extends RejTreeNodeView { +public final class RejTreeValueView extends RejTreeNodeView { private static final long serialVersionUID = 1L; private final RejTreeValueNode _node; diff --git a/Core/src/org/sleuthkit/autopsy/rejview/RejTreeView.java b/Core/src/org/sleuthkit/autopsy/rejview/RejTreeView.java index 757235ad3f..cfce7fae67 100644 --- a/Core/src/org/sleuthkit/autopsy/rejview/RejTreeView.java +++ b/Core/src/org/sleuthkit/autopsy/rejview/RejTreeView.java @@ -37,7 +37,7 @@ import javax.swing.JScrollPane; import javax.swing.JTree; import org.sleuthkit.autopsy.coreutils.Logger; -class RejTreeView extends JScrollPane implements TreeExpansionListener, TreeSelectionListener { +final class RejTreeView extends JScrollPane implements TreeExpansionListener, TreeSelectionListener { private static final Logger logger = Logger.getLogger(HexView.class.getName()); private static final long serialVersionUID = 1L; diff --git a/Core/src/org/sleuthkit/autopsy/rejview/RejView.java b/Core/src/org/sleuthkit/autopsy/rejview/RejView.java index e3a5d91cdf..490efc1873 100644 --- a/Core/src/org/sleuthkit/autopsy/rejview/RejView.java +++ b/Core/src/org/sleuthkit/autopsy/rejview/RejView.java @@ -29,7 +29,7 @@ import java.nio.ByteBuffer; import javax.swing.JPanel; import javax.swing.JSplitPane; -public class RejView extends JPanel implements RejTreeNodeSelectionListener { +public final class RejView extends JPanel implements RejTreeNodeSelectionListener { private static final long serialVersionUID = 1L; private final RegistryHive _hive;