codex-admin/core
1
0
Fork 0
mirror of https://github.com/elisspace/core.git synced 2026-10-04 16:26:19 +00:00
Code Issues Releases Wiki Activity
60,267 Commits 119 Branches 1,121 Tags
engine-component
Commit Graph
25 Commits
Author SHA1 Message Date
J. Nick Koston 03eea7bd3f Avoid subprocess memory copy when c library supports posix_spawn (#87958) 
* use posix spawn on alpine

* Avoid subprocess memory copy when c library supports posix_spawn

By default python 3.10 will use the fork() which has to
copy all the memory of the parent process (in our case
this can be huge since Home Assistant core can use
hundreds of megabytes of RAM). By using posix_spawn
this is avoided.

In python 3.11 vfork will also be available
https://github.com/python/cpython/issues/80004#issuecomment-1093810689
https://github.com/python/cpython/pull/11671 but we won't
always be able to use it and posix_spawn is considered safer
https://bugzilla.kernel.org/show_bug.cgi?id=215813#c14

The subprocess library doesn't know about musl though
even though it supports posix_spawn https://git.musl-libc.org/cgit/musl/log/src/process/posix_spawn.c
so we have to teach it since it only has checks for glibc
https://github.com/python/cpython/blob/1b736838e6ae1b4ef42cdd27c2708face908f92c/Lib/subprocess.py#L745

The constant is documented as being able to be flipped here:
https://docs.python.org/3/library/subprocess.html#disabling-use-of-vfork-or-posix-spawn

* Avoid subprocess memory copy when c library supports posix_spawn

By default python 3.10 will use the fork() which has to
copy memory of the parent process (in our case
this can be huge since Home Assistant core can use
hundreds of megabytes of RAM). By using posix_spawn
this is avoided and subprocess creation does not
get discernibly slow the larger the Home Assistant
python process grows.

In python 3.11 vfork will also be available
https://github.com/python/cpython/issues/80004#issuecomment-1093810689
https://github.com/python/cpython/pull/11671 but we won't
always be able to use it and posix_spawn is considered safer
https://bugzilla.kernel.org/show_bug.cgi?id=215813#c14

The subprocess library doesn't know about musl though
even though it supports posix_spawn https://git.musl-libc.org/cgit/musl/log/src/process/posix_spawn.c
so we have to teach it since it only has checks for glibc
https://github.com/python/cpython/blob/1b736838e6ae1b4ef42cdd27c2708face908f92c/Lib/subprocess.py#L745

The constant is documented as being able to be flipped here:
https://docs.python.org/3/library/subprocess.html#disabling-use-of-vfork-or-posix-spawn

* missed some

* adjust more tests

* coverage
 2023-02-13 09:02:51 -05:00
epenet 9205020fa4 Avoid import homeassistant.const as a module (#85991) 2023-01-16 16:49:49 +01:00
epenet b5402f9b57 Import device tracker constants from root (#78242) 2022-09-12 20:50:44 -04:00
Marc Mueller 450b7cd644 Use device_tracker SourceType enum [n-r] (#75965) 2022-07-31 15:48:43 +02:00
Marc Mueller 003fe9220e Add protocol types for device_tracker async_see and see (#75891) 2022-07-29 00:27:47 +02:00
epenetandepenet 211b99e22d Remove ping from mypy ignored modules (#64439) 
Co-authored-by: epenet <epenet@users.noreply.github.com>
 2022-01-19 20:59:20 +01:00
Erik Montnemery 0fa4f616ed Remove Windows workarounds from ping (#64069) 2022-01-13 20:43:00 +01:00
epenetandepenet 0ac9b62f97 Fix incorrect type hint in async_setup_scanner (#63833) 
Co-authored-by: epenet <epenet@users.noreply.github.com>
 2022-01-10 22:47:24 +01:00
epenetandepenet c6aaa24027 Add type hints to async_setup_scanner (#63826) 
Co-authored-by: epenet <epenet@users.noreply.github.com>
 2022-01-10 16:13:54 +01:00
Ville Skyttä 470f2dd73f Upgrade pyupgrade to 2.21.2, apply its changes (#52987) 2021-07-19 10:46:09 +02:00
J. Nick Koston 68714c2067 Update ping to use asyncio function in icmplib (#50808) 2021-06-02 06:10:33 -10:00
Marc Mueller f1d48ddfe3 Update pylint to 2.8.0 (#49637) 2021-04-24 14:39:24 -10:00
J. Nick Koston 54322f84c5 Do not schedule future ping device tracker updates once hass is stopping (#49236) 2021-04-15 08:49:28 +02:00
J. Nick KostonandPaulus Schoutsen 9b0b2d9168 Prevent ping id allocation conflict with device_tracker (#48969) 
* Prevent ping id allocation conflict with device_tracker

- Solves id conflict resulting unexpected home state

* Update homeassistant/components/ping/device_tracker.py

Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io>
 2021-04-09 16:56:15 -07:00
J. Nick Koston bee55a0494 Prevent ping integration from delaying startup (#43869) 2021-03-31 15:06:49 +02:00
J. Nick Koston c7bbba9d48 Reduce icmplib ping timeout to match ping binary behavior (#41620) 2020-10-11 11:12:27 -05:00
J. Nick Koston b7ad83c655 Use a unique id for each icmplib ping to avoid mixing unrelated responses (#39830) 2020-09-09 22:19:14 +02:00
J. Nick KostonandPaulus Schoutsen 7c191388a9 Use icmplib for ping when available (#39284) 
* Use icmplib for ping when available

* Update homeassistant/components/ping/binary_sensor.py

Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io>

* Revert "Update homeassistant/components/ping/binary_sensor.py"

This reverts commit 618f42512a89834bb8b2ed7830e7e77d79a29f44.

* move it up so its easier to see

Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io>
 2020-08-28 08:50:09 -05:00
J. Nick Koston a91f5b7192 Prevent ping integration from blocking startup (#38504) 2020-08-05 12:43:35 +02:00
springstan 83a79a434c Use slug in ping device tracker config validation (#31329) 
* Use slug instead of string for config validation
 2020-02-08 15:19:46 +01:00
Bas Nijholt 21816eeed4 Sort imports according to PEP8 for components starting with "P" (#29775) 2019-12-09 14:29:39 +01:00
Paulus Schoutsen 4de97abc3a Black 2019-07-31 12:25:30 -07:00
Paulus Schoutsen 70ed58a78d Restructure device tracker (#23862) 
* Restructure device tracker

* Docstyle

* Fix typing

* Lint

* Lint

* Fix tests
 2019-05-15 23:43:45 +02:00
Tobias Sauerwein 048b100eea Clean up docstrings (#22679) 
* Clean up docstrings

* Fix long lines

* Fix more docstrings

* Fix more docstrings

* Fix more docstrings
 2019-04-03 17:40:03 +02:00
Paulus Schoutsen f5076188ef Consolidate all platforms that have no tests (#22096) 
* Consolidate

* Fix tests

* Update imports

* Fix import

* Use importlib because integration and package share name

* Fix more tests

* Update .coveragerc and CODEOWNERS
 2019-03-16 20:44:05 -07:00