Commit Graph
54561 Commits
Author SHA1 Message Date
Ben Randall 55b036ec5e Improve device_automation trigger validation (#75044)
* improve device_automation trigger validation

Validates the trigger configuration against the device_trigger schema before trying to access any of the properties in order to provide better error messages.
Updates the error message to include an explicit indication that the error is coming from a trigger configuration.  The inner error message from the validator can be accessed by viewing the stack trace.
Add test case for trigger missing domain.

Make action and condition validation consistent with trigger.  This is not strictly necessary, but should be helpful for certain use cases that bypass some of the outer validation.

Removed redundant schema elements from humidifier device_trigger.

**Blueprint with missing `domain`**
```
2022-07-12 06:02:18.351 ERROR (MainThread) [homeassistant.setup] Error during setup of component automation
Traceback (most recent call last):
  File "/workspaces/core/homeassistant/setup.py", line 235, in _async_setup_component
    result = await task
  File "/workspaces/core/homeassistant/components/automation/__init__.py", line 241, in async_setup
    if not await _async_process_config(hass, config, component):
  File "/workspaces/core/homeassistant/components/automation/__init__.py", line 648, in _async_process_config
    await async_validate_config_item(hass, raw_config),
  File "/workspaces/core/homeassistant/components/automation/config.py", line 74, in async_validate_config_item
    config[CONF_TRIGGER] = await async_validate_trigger_config(
  File "/workspaces/core/homeassistant/helpers/trigger.py", line 59, in async_validate_trigger_config
    conf = await platform.async_validate_trigger_config(hass, conf)
  File "/workspaces/core/homeassistant/components/device_automation/trigger.py", line 67, in async_validate_trigger_config
    hass, config[CONF_DOMAIN], DeviceAutomationType.TRIGGER
KeyError: 'domain'
```

**Blueprint with missing `property` (specific to zwave_js event schema)**
```
2022-07-12 06:09:54.206 ERROR (MainThread) [homeassistant.components.automation] Blueprint Missing Property generated invalid automation with inputs OrderedDict([('control_switch', '498be56d796836a67406e9ad373d23db')]): required key not provided @ data['property']. Got None
```

**Blueprint with missing `domain`**
```
2022-07-12 06:12:16.080 ERROR (MainThread) [homeassistant.components.automation] Blueprint Missing Domain generated invalid automation with inputs OrderedDict([('control_switch', '498be56d796836a67406e9ad373d23db')]): invalid trigger configuration: required key not provided @ data['domain']. Got <homeassistant.components.blueprint.models.BlueprintInputs object at 0x7f581e097820>
```

**Blueprint with missing `property` (specific to zwave_js event schema)**
```
2022-07-12 06:12:16.680 ERROR (MainThread) [homeassistant.components.automation] Blueprint Missing Property generated invalid automation with inputs OrderedDict([('control_switch', '498be56d796836a67406e9ad373d23db')]): invalid trigger configuration: required key not provided @ data['property']. Got <homeassistant.components.blueprint.models.BlueprintInputs object at 0x7f581c0dc9d0>
```

* Revert humifidier TRIGGER_SCHEMA change.
2022-10-03 16:42:57 +02:00
Maikel Punie 40bdcc3ea7 Bump velbusaio to 2022.10.2 (#79537) 2022-10-03 16:17:08 +02:00
J. Nick Koston aa3aa91358 Bump dbus-fast to 1.22.0 (#79527)
Performance improvements
https://github.com/Bluetooth-Devices/dbus-fast/compare/v1.21.17...v1.22.0
2022-10-03 15:11:51 +02:00
Maikel Punie cb909b4b05 Bumb velbusaio to 2022.10.1 (#79471) 2022-10-03 11:44:20 +02:00
Erik Montnemery 0fdb7052e9 Add comment in recorder about dropping column (#79523)
Add comment in recorder
2022-10-03 11:40:11 +02:00
Hans Oischinger 125c037def Address late review of ViCare (#79458)
Runn blocking I/O of button entity creation in async_add_executor_job
2022-10-03 11:10:25 +02:00
Robert Svensson c05d3c10db Address late comment to deCONZ climate (#79485)
Fix late comment to deCONZ climate #59989
2022-10-03 11:06:13 +02:00
epenet 825f9502ad Align temperature conversion with other converters (#79521)
* Align temperature conversion with other converters

* Add comments and docstring

* Align tests
2022-10-03 10:09:55 +02:00
ehendrix23 47b40e1e61 Add optional default value to average template function/filter (#77499)
* Return None on empty list

* Updated to use default value

* Update comment.
2022-10-03 10:07:19 +02:00
Paulus Schoutsen 61f0d0ea15 Update Nest string (#79516) 2022-10-02 18:51:46 -07:00
Nyro 0431575199 Fix overkiz entity name (#79229) 2022-10-02 21:22:20 -04:00
Michael d7be3c8780 Set Synology DSM update entity to unavailable in case no data from api gathered (#79508) 2022-10-02 21:19:37 -04:00
IceBotYT d6a6d0d754 Fix LaCrosse View not updating (#79474) 2022-10-02 21:14:02 -04:00
J. Nick Koston da960f6ed4 Bump bluetooth dependencies (#79514) 2022-10-02 21:12:14 -04:00
Michael 790eb9e72d Remove deprecated update binary sensor from Synology DSM (#79509) 2022-10-02 21:11:45 -04:00
Jesse Hills 8676012204 Bump aioesphomeapi to 11.1.0 (#79515) 2022-10-02 21:11:18 -04:00
GitHub Action 12358f2446 [ci skip] Translation update 2022-10-03 00:31:05 +00:00
Raman Gupta 3a8282d0c5 Improve zwave_js service error (#79504) 2022-10-02 23:24:06 +02:00
Maciej Bieniek 3b794038b1 Add reauth flow to BraviaTV integration (#79405)
* Raise ConfigEntryAuthFailed

* Add reauth flow

* Add tests

* Patch pair() method to avoid IO

* Remove unused errors dict
2022-10-02 13:07:57 -07:00
Bram Kragten f28e3fb46c Update frontend to 20221002.0 (#79491) 2022-10-02 21:30:54 +02:00
Robert Svensson 14f60dc871 Fix missing string message in UniFi (#79487) 2022-10-02 14:50:01 -04:00
zbeky 81b940ec17 Add EVOLVEO Heat M30v2 TRV (#79462) 2022-10-02 14:34:53 -04:00
TheJulianJES d58e16b990 Fix empty default ZHA configuration (#79475)
* Also add 0 as a default for transition in const.py

This is the same default transition (none) that is used in ZHA's light.py

* Send default values for unconfigured options in ZHA's configuration API

* Remove options that match defaults values before saving
2022-10-02 14:34:15 -04:00
Hung Nguyen 069818940e Skip parsing Flume sensors without location (#79456) 2022-10-02 12:47:07 -04:00
J. Nick Koston 653620345c Bump dbus-fast to 1.20.0 (#79465) 2022-10-02 12:46:01 -04:00
Maximilian 7aacdec8e1 Address late review of nina (#79467)
* Address review

* Remove unused attribute
2022-10-02 08:57:32 -07:00
David F. Mulcahey 547a63e314 Remove unnecessary config entity from ZHA (#79472) 2022-10-02 11:07:19 -04:00
Ryan Fleming 2ea9732419 Support reauth for octoprint (#77213)
* Add reauth flow to octoprint

* Add unit tests around octoprint reauth

* Add missing strings

* Fix unit test mocks
2022-10-02 08:08:45 +02:00
Allen Porter 28809fc7fd Remove dead code code in calendar (#79450) 2022-10-01 23:07:27 -07:00
Ryan Fleming 229e387a1d Bump pyoctoprintapi to version 1.9 (#79449)
Bump to version 1.9
2022-10-01 22:05:53 -07:00
Marc Mueller 89d0b434bc Use explicit return value in azure_event_hub (#79315)
* Use explicit return value in azure_event_hub

* Use abstractmethod
2022-10-01 21:24:25 -07:00
Maximilian 7ae942a62b Fix nina warning state (#76354)
* Fix warning state

* Improve data handling

* Remove duplicate code
2022-10-01 21:22:18 -07:00
Avi Miller 205ce2bac5 Refactor LIFX multizone devices to use extended messages (#79444) 2022-10-01 18:21:48 -10:00
Jevgeni Kiski f95b8ccc20 Improve vallox tests and code quality (#75787)
code quality improvements
2022-10-01 21:13:15 -07:00
Rami Mosleh 38a680c3eb Add reauthenticaion to mikrotik (#74454) 2022-10-01 20:37:24 -07:00
Allen Porter 7b8b73f826 Update nest climate to avoid duplicate set mode commands (#79445) 2022-10-01 21:59:10 -04:00
J. Nick Koston 8a73795f50 Bump bluetooth-adapters to 0.5.3 (#79442) 2022-10-01 21:27:44 -04:00
Tobias SauerweinandPaulus Schoutsen 3e411935bb Fix Netatmo scope issue with HA cloud (#79437)
Co-authored-by: Paulus Schoutsen <balloob@gmail.com>
2022-10-01 21:11:54 -04:00
J. Nick Koston ebc2a751d2 Bump ibeacon-ble to 0.7.3 (#79443) 2022-10-01 20:48:09 -04:00
J. Nick Koston d9191cf2f2 Bump dbus-fast to 1.18.0 (#79440)
Changelog: https://github.com/Bluetooth-Devices/dbus-fast/compare/v1.17.0...v1.18.0
2022-10-01 14:45:01 -10:00
Michael a3cd03b70b Fix checking of upgrade API availability during setup of Synology DSM integration (#79435) 2022-10-01 20:43:15 -04:00
J. Nick Koston dac60990ee Ensure bluetooth disconnect callback fires if esphome config entry is reloaded (#79389) 2022-10-01 20:42:54 -04:00
Allen Porter d03553bbf0 Address Google Sheets PR feedback (#78889) 2022-10-01 20:42:11 -04:00
GitHub Action 13c8d22baf [ci skip] Translation update 2022-10-02 00:37:00 +00:00
J. Nick Koston 5055d3ff4b Enable delete device support for iBeacon (#79339) 2022-10-01 14:17:45 -10:00
kingy444 50952f8a1c Powerview bump aiopvapi to 2.0.2 (#79274) 2022-10-01 14:16:16 -10:00
Matrix 944d704011 Fix mqtt reconnect fail when token expired (#79428)
* fix mqtt reconnect fail when token expired

* suggest change
2022-10-02 01:56:36 +03:00
Steven Looman 083db97476 Sort motioneye media items in media browser (#79408)
* Sort media

* KEY_MEDIA_SORT_ATTR should be in const

* Changes after review
2022-10-02 00:36:03 +02:00
Shay Levy f64a4f4a95 Bump aiowebostv to 0.2.1 (#79423) 2022-10-02 00:32:27 +02:00
Garrett 9058b5b9c3 Update sensors for Subaru integration (#66996)
* Update sensor.py

* Change "EV Time to Fully Charged" type to datetime object (HA 2022.2)

* Validate types before accessing dict entries

* Test handling of invalid data from Subaru

* Bump to subarulink 0.4.2

* Incorporate style suggestion

* Update sensor.py to use SensorEntity

* isort tests

* Remove SubaruSensor.current_value

* Fix isort errors

* Resolve conflict from previous PR (add locks)

* Fix linting errors in config_flow.py

* Incorporate PR review comments for sensor

* Incorporate PR review comments for sensor

* Make 3rd party library responsible for API data parsing

* Add type annotations to sensor.py

* Incorporate PR review comments

* Incorporate PR review comments

* Set _attr_has_entity_name = True for sensors
2022-10-02 00:25:49 +02:00